Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tonybaloney.vscode-pets #808

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

JarenGarman
Copy link
Contributor

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR adds the vscode-pets extension to the extensions.json because the author does not seem to be interested in doing it themselves

@filiptronicek
Copy link
Member

Hey @JarenGarman and thanks for the contribution. I've searched around and found tonybaloney/vscode-pets#9 (comment), which explains why this can't be published in the original repo.

Looks like the extension build went smoothly, we'll just need you to sign the Eclipse Contributor Agreement (link in PR checks) to get this merged.

@zalsader
Copy link

Please note that a page exists in openvsix for this extension, but it seems to be severely out of date: https://open-vsx.org/extension/tonybaloney/vscode-pets

@JarenGarman
Copy link
Contributor Author

Hey @JarenGarman and thanks for the contribution. I've searched around and found tonybaloney/vscode-pets#9 (comment), which explains why this can't be published in the original repo.

Looks like the extension build went smoothly, we'll just need you to sign the Eclipse Contributor Agreement (link in PR checks) to get this merged.

Signed, thank you!

@filiptronicek
Copy link
Member

@JarenGarman could you share with me the email address you signed the agreement with? I tried re-validating here, and it seems like we got an error again 🙏

@JarenGarman
Copy link
Contributor Author

@filiptronicek I just double checked and apparently my ECA didn't go through the first time lol. thanks for letting me know, I resubmitted and reverified, looks like that check is passing now

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, let's ship this then!

@filiptronicek filiptronicek changed the title Add vscode-pets Add tonybaloney.vscode-pets Jan 29, 2025
@filiptronicek filiptronicek merged commit 1f23333 into EclipseFdn:master Jan 29, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants